Skip to content

JWKS Content Type #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Conversation

jschlyter
Copy link
Collaborator

The current code emits a warning if the JWKS content type is anything other than application/json. This is suboptimal as RFC 7517 specifies application/jwk+json.

@jschlyter jschlyter requested a review from a team as a code owner March 4, 2025 06:57
@jschlyter jschlyter requested review from lionick and rohe and removed request for a team March 4, 2025 06:57
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (9e094e3) to head (a2c8558).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/cryptojwt/key_bundle.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   76.42%   76.45%   +0.02%     
==========================================
  Files          44       44              
  Lines        4484     4489       +5     
  Branches      839      841       +2     
==========================================
+ Hits         3427     3432       +5     
  Misses        777      777              
  Partials      280      280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jschlyter jschlyter requested review from a team and removed request for lionick March 4, 2025 08:07
@jschlyter
Copy link
Collaborator Author

@coderabbitai review

@jschlyter jschlyter merged commit e1100fe into IdentityPython:main Mar 17, 2025
9 checks passed
@jschlyter jschlyter deleted the jwks_content_type branch March 17, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants